Draft
Conversation
Cuildipie
previously approved these changes
Jun 8, 2025
This comment was marked as outdated.
This comment was marked as outdated.
f062702 to
4923396
Compare
33bce74 to
1345997
Compare
This comment was marked as resolved.
This comment was marked as resolved.
4d4480c to
b0c2fb0
Compare
This fix commit 48f9dbf.
5853
a7f56fa to
6413162
Compare
c3ec945 to
d1fdcd0
Compare
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Meant to fix the various docking issues ive noticed over the past few uptimes, along with making some player facing docking stuff easier to comprehend. Meant to be a minor PR, you know the old song and dance In no particular order: - Makes docking error messages less fucking vauge and weird. This isn't even because they're player facing, this is because i geniuely couldnt figure out wtf they meant without looking up the code. This means an admin might actually figure out what is causing a particular docking issue - - Some more docking errors for for adjustable docks since those handle docking different from regular docks. - Fixes improperly mapped docking ports on some ships - - Firefly docking port is no longer extremely dangerous due to missing `disable_on_owner_ship_dock` - - June's Docking port now can dock to other ships - Fixes slimegirl that occurs due to ships sometimes stealing the mobile or even transit docking port from other ships. This should in theory make ship to ship docking a lot less fucked up, but also long rounds (>4 hours) should be a lot more stable - - Should make docking ports a lot less prone to random breakages and errors - Adds edgecase handling for a fair bit of ship code - - Makes Very Big ships have less janky transit zones - - Checking if a ship can dock to an adjustable dock doesn't actually said dock anymore, saving perf and making adjust. docking port bugs less common - Quick dock is now Actually Quick. it should search all docking ports on an overmap object (barring outposts, those have their own handling) to find one that you can actually dock to - Uploading shuttle map templates no longer breaks the overmap sprite due to missing faction datum Needs TM During an early round due to it touching pretty vital code. Otherwise, it shouldn't be noticable too much. ## Why It's Good For The Game Working shipcode that works better is good. ## Changelog :cl: add: Quick dock now searches for docking ports your ship can land at, rather than picking the first option and failing. Quicker! add: Makes docking port messages less vauge. add: Adjusts transit vlevel sizes for larger ships add: In case you are unable to dock to something, you should be given more feedback fix: Shuttle errors due to docking ports being stolen fix: Edgecase handling for docking ports, should fix very rare shuttle bugs fix: Kali, Corona, Dwayne, Firefly, Scarab, Venetia, Typhoon, June, and especially the Quasar have either proper docking ports or fixed docking ports fix: Firefly is now not extremely dangerous to dock to fix: Shuttle code should be less prone to breaking in general /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Signed-off-by: rye-rice <58402542+rye-rice@users.noreply.github.com> Co-authored-by: retlaw34 <58402542+retlaw34@users.noreply.github.com> Co-authored-by: Sarah C <93578146+SapphicOverload@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Вечный ПР
Important
Вечный ПР, где изначально все тестируется напрямую на Альфе. После уже отделяется в отдельные ПРы.
Список изменений